I guess this needs to be updated @gazorby

Hey @Goldziher and @gazorby ! I ran the test suite and the test for Python 3.7 and 3.8 are failing. Could you have a look: https://github.com/getsentry/sentry-python/actions/runs/3866938112/jobs/6611898016

Should be fixed now @antonpirker!

Thanks for the update!

Now please skip the tests if the starlite package is not installed. Similar like we do in starlette tests: https://github.com/getsentry/sentry-python/blob/master/tests/integrations/starlette/__init__.py (this should fix the failing opentelemetry tests)

And in the test_starlite.py there are some unused imports, please remove them:
https://github.com/getsentry/sentry-python/actions/runs/3878616735/jobs/6621266350

You can run the linters locally by running tox -e linters, or if you do not have tox installed, you can install linter-requirements.txt and then call those commands locally: https://github.com/getsentry/sentry-python/blob/master/tox.ini#L411-L413 (preferably running in Python 3.9 to have the exact same setup like the CI)
(running this locally, should prevent more back and forth)

First @gazorby and @Goldziher: Great work!

I have now created a demo app like this:

When I access the endpoint the error that ends up in Sentry as "generic Starlite request" and I am not sure why not a proper transaction name is set:

Could you please check if you can get a proper name or tell me what I do wrong?

Should be fixed now @antonpirker

I started the tests again, and will review again tomorrow! Thanks for the quick fixes!

Ok, we have now nice transaction names!

All the tests are also green now! Nice work!

The things missing now @gazorby is in my two comments in the review. (One is just nitpicking, so feel free to ignore)

One thing I also noticed is that there is only endpoint in transaction_style. In other integrations we have also url, but most of the time endpoint is the default, so I guess this is fine. If a lot of users demand url style transaction names in the future, we can always add it.

One last thing @gazorby . See above!

@antonpirker As I refactored utils.transaction_from_function to support partials, django.signal_handlers._get_receiver_name
(and maybe other stuff as well) may benefit from it, should we deduplicate here or do this in another PR?

please in another PR.

I think we are good to go! Amazing work @gazorby, thanks a lot!

We will try to ship a new version of the SDK this week.

If you send me your shipping address to anton (dot) pirker {at} sentry .dot. io I can send you a little bit of swag as a small "thank you".

Thanks @antonpirker!

Thanks @gazorby!

Starlite support has been released in version 1.13.0 of the Sentry SDK:
https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md

Thanks for the quick release @antonpirker !

No problem! Do not forget to send me your shipping address and t-shirt size to [email protected]