Skip to content

fix(compiler): fixes animations on elements with structural directives #63390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(compiler): fixes animations on elements with structural directives #63390

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Aug 26, 2025

The animate instructions were getting applied to the container comment nodes as well as the element nodes. This prevents that on the compiler level.

fixes: #63371

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Aug 26, 2025
@ngbot ngbot bot modified the milestone: Backlog Aug 26, 2025
crisbeto
crisbeto reviewed Aug 26, 2025
View reviewed changes
@thePunderWoman thePunderWoman force-pushed the animate-input-bindings branch 4 times, most recently from f09b6bc to 9b62c6e Compare August 26, 2025 11:08
crisbeto
crisbeto approved these changes Aug 26, 2025
View reviewed changes
@thePunderWoman
fix(compiler): fixes animations on elements with structural directives
2b87772 
The animate instructions were getting applied to the container comment nodes as well as the element nodes. This prevents that on the compiler level.

fixes: angular#63371
@thePunderWoman thePunderWoman force-pushed the animate-input-bindings branch from 9b62c6e to 2b87772 Compare August 26, 2025 11:13
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 26, 2025
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Aug 26, 2025

This PR was merged into the repository. The changes were merged into the following branches:

AndrewKushnir pushed a commit that referenced this pull request Aug 26, 2025
@thePunderWoman @AndrewKushnir
fix(compiler): fixes animations on elements with structural directives (
d7b6045 
#63390)

The animate instructions were getting applied to the container comment nodes as well as the element nodes. This prevents that on the compiler level.

fixes: #63371

PR Close #63390
@thePunderWoman thePunderWoman deleted the animate-input-bindings branch September 12, 2025 16:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 13, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

animate.enter fails at runtime when used on a element with a structural directive

3 participants

@thePunderWoman @AndrewKushnir @crisbeto