Skip to content

Updated the urllib + http libraries + test libraries #6672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
terryluan12 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Updated the urllib + http libraries + test libraries #6672

terryluan12 wants to merge 4 commits into from
+1,927 −786

Conversation

@terryluan12
Copy link
Contributor

@terryluan12 terryluan12 commented Jan 7, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 changed the title Updated the urllib + http libraries Updated the urllib + http libraries + test libraries Jan 7, 2026
@terryluan12 terryluan12 changed the title Updated the urllib + http libraries + test libraries Updated the urllib + http libraries + test libraries + test_contextlib_async.py Jan 7, 2026
@terryluan12 terryluan12 marked this pull request as draft January 7, 2026 02:22
youknowone
youknowone reviewed Jan 7, 2026
View reviewed changes
Lib/enum.py Outdated
Comment on lines 1760 to 1761
# TODO: RUSTPYTHON; Currently, __new__ is not treated specially in __dict__
# new_member = __new__.__func__
Copy link
Member

@youknowone youknowone Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens without this patch?

Copy link
Contributor Author

@terryluan12 terryluan12 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! That error was why I added #6658. Now that it's resolved, it should be good to uncomment. I'll give it a shot after I finish testing asyncio

@terryluan12 terryluan12 force-pushed the update_urllib_http branch 2 times, most recently from aa54aa7 to 86edf1d Compare January 7, 2026 05:59
ShaharNaveh
ShaharNaveh reviewed Jan 7, 2026
View reviewed changes
Lib/test/test_contextlib_async.py
Copy link
Collaborator

@ShaharNaveh ShaharNaveh Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes of this file can be in their own PR

@terryluan12 terryluan12 force-pushed the update_urllib_http branch 2 times, most recently from ac5387b to b44d087 Compare January 10, 2026 07:29
@terryluan12 terryluan12 changed the title Updated the urllib + http libraries + test libraries + test_contextlib_async.py Updated the urllib + http libraries + test libraries Jan 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:

git pull origin update_urllib_http

fanninpm
fanninpm reviewed Jan 11, 2026
View reviewed changes
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these in-line comments, I was wondering if the tests currently marked with this:

    @unittest.skipIf(os.name == 'nt', 'TODO: RUSTPYTHON; ValueError: illegal environment variable name')

…could be replaced with this:

    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON; ValueError: illegal environment variable name')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone left review comments

@fanninpm fanninpm fanninpm left review comments

+1 more reviewer

@ShaharNaveh ShaharNaveh ShaharNaveh left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terryluan12 @youknowone @fanninpm @ShaharNaveh