Skip to content

feat: bind overridden value converters to the target #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
triniwiz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: bind overridden value converters to the target #11018

triniwiz wants to merge 2 commits into from

Conversation

@triniwiz
Copy link
Member

@triniwiz triniwiz commented Dec 30, 2025

When a overridden property valueConverter is called it will now be bound to the target which can be useful for custom views detecting how to handle the incoming value

fontSizeProperty.overrideHandlers({
  name: 'fontSize',
  cssName: 'font-size',
  valueConverter: function (value) {
    if (this && this[isACustomView_]) {
      return value as never;
    }
    // fallback to core conversion
    return parseFloat(value as never);
  },

@nx-cloud
Copy link

nx-cloud bot commented Dec 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 59e3dee

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 3m 5s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-01 18:27:49 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@triniwiz