Specify the webdriver command to open terms of service and privacy po…#610
Open
cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
Open
Specify the webdriver command to open terms of service and privacy po…#610cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
cbiesinger wants to merge 1 commit intow3c-fedid:mainfrom
Conversation
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 3, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
7 tasks
npm1
reviewed
Jun 4, 2024
| 1. If |dialogButton| is "`TermsOfService`" or "`PrivacyPolicy`": | ||
| 1. If no FedCM dialog is currently open or the dialog is not a dialog that | ||
| lets a user select an account, return a [=error|WebDriver error=] with | ||
| [=error code=] [=no such alert=]. |
Collaborator
There was a problem hiding this comment.
Is this the right error code?
Collaborator
Author
There was a problem hiding this comment.
It's the code I've been using for all the webdriver commands. It seemed close enough and I wanted to avoid defining a new error code.
npm1
approved these changes
Jun 4, 2024
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 5, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
force-pushed
the
webdriver2
branch
from
460e396 to
63259a0
Compare
npm1
approved these changes
Sep 12, 2024
Collaborator
npm1
left a comment
npm1
left a comment
There was a problem hiding this comment.
Not sure what was the recent change but lgtm
Collaborator
Author
|
The change was reformatting and also changing the error to invalid selector (from invalid argument) here: |
Collaborator
Author
|
@bvandersloot-mozilla could you take a look? |
ghost
approved these changes
Mar 9, 2025
TallTed
suggested changes
Mar 10, 2025
Contributor
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Multiple "if" conditions deserve the clarity of a "then"
Comment on lines
+2203
to
+2206
| 1. If |index| is not an integer, or is less than zero or greater than | ||
| or equal to the number of accounts that the user can choose from in the | ||
| current flow, return a [=error|WebDriver error=] with [=error code=] | ||
| [=invalid argument=]. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. If |index| is not an integer, or is less than zero or greater than | |
| or equal to the number of accounts that the user can choose from in the | |
| current flow, return a [=error|WebDriver error=] with [=error code=] | |
| [=invalid argument=]. | |
| 1. If |index| is not an integer, or is less than zero, or is greater than | |
| or equal to the number of accounts that the user can choose from in the | |
| current flow, then return a [=error|WebDriver error=] with [=error code=] | |
| [=invalid argument=]. |
Comment on lines
+2207
to
+2214
| 1. If the account at |index| does not have a terms of service or privacy | ||
| policy URL, either because none was provided in the [=client metadata | ||
| endpoint=] or because [=compute the connection status=] for the account | ||
| returned [=compute the connection status/connected=], return a | ||
| [=error|WebDriver error=] with [=error code=] [=invalid selector=]. | ||
| 1. Otherwise, if |dialogButton| is "`TermsOfService`", open the account's | ||
| {{IdentityProviderClientMetadata/terms_of_service_url}}, or if | ||
| |dialogButton| is "`PrivacyPolicy`", open the account's |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. If the account at |index| does not have a terms of service or privacy | |
| policy URL, either because none was provided in the [=client metadata | |
| endpoint=] or because [=compute the connection status=] for the account | |
| returned [=compute the connection status/connected=], return a | |
| [=error|WebDriver error=] with [=error code=] [=invalid selector=]. | |
| 1. Otherwise, if |dialogButton| is "`TermsOfService`", open the account's | |
| {{IdentityProviderClientMetadata/terms_of_service_url}}, or if | |
| |dialogButton| is "`PrivacyPolicy`", open the account's | |
| 1. If the account at |index| does not have a terms of service or privacy | |
| policy URL, either because none was provided in the [=client metadata | |
| endpoint=] or because [=compute the connection status=] for the account | |
| returned [=compute the connection status/connected=], then return a | |
| [=error|WebDriver error=] with [=error code=] [=invalid selector=]. | |
| 1. Otherwise, if |dialogButton| is "`TermsOfService`", open the account's | |
| {{IdentityProviderClientMetadata/terms_of_service_url}}, or if | |
| |dialogButton| is "`PrivacyPolicy`", then open the account's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…licy
Fixes #627
Preview | Diff