Refactored expectations on compound data #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the reporting of differences is unified across: `unordered`, `ordered` and `join_by` comparison.
|
Kudos, SonarCloud Quality Gate passed!
|
lwasylow
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the reporting of differences is unified across:
unordered,orderedandjoin_bycomparison.Up until now, when using
unorderedorjoin_bythe differences were reported column by column as opposed to diff of entire row in one-line, as it is when using default data-set compare method.This was making reports hard to read and interpret.
Also signal-to-noise ration was pretty bad, as each new line was repeating
join_bycolumns.The change addresses this issue.
Additionally,
unordered_columnsdiff report is now showing expected and actual columns in the same order for rows that contain differences.You may see the differences by looking into changed test lines