fix/enhancement: removes over-approval, adds manual approve#136
Merged
ErikBjare merged 16 commits intouniswap-python:masterfrom Jul 12, 2021
Merged
fix/enhancement: removes over-approval, adds manual approve#136ErikBjare merged 16 commits intouniswap-python:masterfrom
ErikBjare merged 16 commits intouniswap-python:masterfrom
Conversation
Co-authored-by: Erik Bjäreholt <[email protected]>
Co-authored-by: Erik Bjäreholt <[email protected]>
Co-authored-by: Erik Bjäreholt <[email protected]>
Co-authored-by: Erik Bjäreholt <[email protected]>
Member
|
Nice, thanks! Squashing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
check_approval()decorator should check/approve first token only, there is no practical reason to check second actually. _approve() method becomes public to let users approve manually.