feat: initial work on v3#106
Conversation
| # FIXME: How to calculate this properly? | ||
| # - https://docs.uniswap.org/reference/libraries/SqrtPriceMath | ||
| # - https://github.com/Uniswap/uniswap-v3-sdk/blob/main/src/swapRouter.ts | ||
| sqrtPriceLimitX96 = 0 |
There was a problem hiding this comment.
This is new, haven't looked into it...
Also, uniswap-v3-sdk is a great reference.
|
Been investigating some weirdness in the Quoter:
https://docs.uniswap.org/reference/periphery/interfaces/IQuoter Found @shanefontaine's post https://medium.com/authereum/getting-ethereum-transaction-revert-reasons-the-easy-way-24203a4d1844, but would need the equivalent for Python lol |
|
All v3 tests are now passing for me locally. Not sure why CI is failing... However, two tests for v2 are failing, as well as one for v1. Probably going to merge this for now, we can continue the work in a follow-up PR. |
|
I just remembered that CI is likely failing due not having access to secrets in PRs (maybe it's just because the branch is on my own fork?). After some debugging, I got the tests to print this: |
|
Tried setting the secret in my own fork, but no success. Gonna merge this and hope for the best... |
No description provided.