-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
bugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a lookWaiting for team members to take a look
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
Changing method definition style is not purely stylistic and may cause TypeScript to report more or fewer errors after the change. Therefore, the autofix cannot be considered safe (I expect autofixes not to alter logic) and I believe it should be downgraded to a suggestion.
How to reproduce:
1. Clone https://github.com/JoshuaKGoldberg/eslint-plugin-package-json
2. Set up the repo, run `pnpm typecheck` and ensure there are no errors
3. Change the method definition style at `src/createRule.ts#L51`
4. Run `pnpm typecheck` and observe new errorsESLint Config
module.exports = {
parser: "@typescript-eslint/parser",
rules: {
"@typescript-eslint/method-signature-style": ["error", "property"],
},
};tsconfig
Expected Result
Autofix is enabled.
Actual Result
Autofix is disabled.
Additional Info
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a lookWaiting for team members to take a look
{ "compilerOptions": { // ... } }