-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Added support for style direction property (ltr/rtl) #10691
Draft
CatchABus
wants to merge
16
commits into
NativeScript:main
Choose a base branch
from
CatchABus:feat/css-direction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


PR Checklist
What is the current behavior?
Right now, core has no support for enforcing a layout direction.
What is the new behavior?
Added css
directioninherited property for a minimal RTL support.This property will use the native APIs of each platform which means that enforcing a layout direction will automatically provide the default native direction experience.
For example, iOS UINavigationBar will align back button to the right in the case of RTL.
The following cases will additionally be affected by layout direction:
slidetransition will slide to the right in the case of RTL directionfliptransition will flip to the left in the case of RTL direction (it used to and will flip to the right in the case of LTR)startandendvalues tohorizontalAlignmentproperty in order for views to be able to align based on layout directionLabeldefault or initial text alignment shall respect the layout directionhasRtlSupporthelper function to determine whether an app supports RTL (it's always true for iOS)FlexboxLayoutlayout direction support for flex alignment and directionFew things to consider:
startandendvalues yet. It's doable but will require extra workaround for iOS since it only providesleftandrightfor aligning to each side. For the time being, users can rely ontext-align: initialthe default of which isleftfor LTR andrightfor RTLandroid:supportsRtl="true"flag to Application tag inAndroidManifest.xmlin order to support itNativeScript app templates shall not support RTL by default since it adds extra burden to layout and processing and it's a feature meant for a small number of languages.
User is responsible to enable RTL in one's own app using
android:supportsRtl="true".This PR adds a set a features to have as many needs as possible based on #7094 #9465 requests.
Fixes/Implements/Closes #6051 #6156.