Skip to content

Add max_trials scheduler config parameter #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
motus merged 24 commits into from
Mar 19, 2024
Merged

Add max_trials scheduler config parameter #719

motus merged 24 commits into from
Mar 19, 2024

Conversation

@motus
Copy link
Member

@motus motus commented Mar 19, 2024 •
edited
Loading

maybe merge after #713 (they might conflict)

Part of issue #715

motus and others added 11 commits March 13, 2024 14:29
@motus
increment the interation counter in suggest() instead of register() a…
f5f224e 
…nd remove the is_warm_up flag
@motus
explicit warm-up run in the scheduler; minor fixes to logging
320dd53
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/opt/ite…
e9188e5 
…r_suggest
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/opt/ite…
7ccce80 
…r_suggest
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/opt/ite…
e018ad2 
…r_suggest
@motus
bugfix: check the itneration count in .not_converged()
8e15ac5
@motus
all unit tests pass
5c21fcc
@motus
fix max_iterations command-line option
385ba84
@bpkroth
Merge branch 'main' into sergiym/opt/iter_suggest
570ee61
@motus
use --max_suggestions instead of --max_iterations in all configs
c50ff19
@motus
add max_trials scheduler config parameter
2d6fc28
@motus motus self-assigned this Mar 19, 2024
@motus motus requested a review from a team as a code owner March 19, 2024 00:39
bpkroth
bpkroth reviewed Mar 19, 2024
View reviewed changes
motus and others added 11 commits March 19, 2024 13:03
@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-sche…
a79e119 
…ma.json

Co-authored-by: Brian Kroth <[email protected]>
@motus @bpkroth
Update mlos_bench/mlos_bench/tests/optimizers/grid_search_optimizer_t…
b4cbd17 
…est.py

Co-authored-by: Brian Kroth <[email protected]>
@motus
rename _get_optimizer_suggestions to _schedule_new_optimizer_suggestions
8f82bea
@motus
add --trial-config-repeat-count 3 to mlos_bench example in README
1368659
@motus @bpkroth
Update mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-sche…
5575718 
…ma.json

Co-authored-by: Brian Kroth <[email protected]>
@motus
Merge branch 'main' into sergiym/opt/iter_suggest
2e1709a
@motus
Merge branch 'sergiym/opt/iter_suggest' into sergiym/sched/max_trials
9ff985b
@motus
Merge branch 'main' into sergiym/sched/max_trials
e13f31d
@motus
Merge branch 'sergiym/sched/max_trials' of github.com:motus/MLOS into…
247e1a9 
… sergiym/sched/max_trials
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/sched/m…
deee444 
…ax_trials
@motus
e not_done() instead of not_converged(); allow -1 for max_trials in c…
398030f 
…onfigs
@motus motus enabled auto-merge (squash) March 19, 2024 21:51
bpkroth
bpkroth reviewed Mar 19, 2024
View reviewed changes
@motus motus merged commit f25e09f into microsoft:main Mar 19, 2024
@motus motus deleted the sergiym/sched/max_trials branch March 19, 2024 22:57
@motus motus mentioned this pull request Mar 19, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels

mlos-bench ready for review Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@motus @bpkroth