Correctly set the mongodb URL in the environment. #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Sep 22, 2025
ralt
force-pushed
the
pr/mongodb-host
branch
from
8567a41 to
b9ddbae
Compare
The path was actually setting `authSource`, not the URL's path, so this was broken to begin with, as has been pointed out in symfony-cli#458 already. That said, some Symfony Cloud systems somehow forgot to expose the `port` in the relationships, and as such, just "fixing" that would break existing systems. This commit does 2 things: 1. Introduces a BC-mode where if the provided `host` is a fully-formed URL, we use it as-is 2. Creates a correct URL from the endpoint, avoiding any future issues related to string parsing.
ralt
force-pushed
the
pr/mongodb-host
branch
from
b9ddbae to
85542e8
Compare
fabpot
approved these changes
Sep 22, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path was actually setting
authSource, not the URL's path, so this was broken to begin with, as has been pointed out in #458 already.That said, some Symfony Cloud systems somehow forgot to expose the
portin the relationships, and as such, just "fixing" that would break existing systems.This commit does 2 things:
hostis a fully-formed URL, we use it as-is