Skip to content

Conversation

@wouterj
Copy link
Member

@wouterj wouterj commented Apr 11, 2020

Fixes #13484

@wouterj wouterj added this to the 5.1 milestone Apr 11, 2020
@wouterj wouterj requested a review from weaverryan April 11, 2020 19:39
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code/doc additions :)

@wouterj wouterj force-pushed the issue-13484/logout-listener-event branch from 88fe387 to 00089a6 Compare April 12, 2020 13:37
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2 minor comments only :)

@wouterj wouterj force-pushed the issue-13484/logout-listener-event branch from 00089a6 to 1d77a45 Compare April 17, 2020 11:42
@wouterj wouterj merged commit 3ef6848 into symfony:master Apr 17, 2020
@wouterj wouterj deleted the issue-13484/logout-listener-event branch April 17, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Refactor logout listener to dispatch an event instead

5 participants