[TwigBundle] Align TemplateIterator handling of @! original bundle templates with TwigExtension #62810
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: TemplateIterator not discovering templates with @! namespace prefix
The
TemplateIterator(used by the cache warmer) was not discovering templates registered with the@!namespace prefix, even thoughTwigExtensionregisters them with the Twig loader. This caused incomplete cache warming for templates referenced as@!BundleName/template.twigduringcache:warmup, requiring additional compilation at runtime.Example:
Before: Only
@Foo/index.html.twigwas compiled duringcache:warmupAfter: Both
@Foo/index.html.twigand@!Foo/index.html.twigare compiled duringcache:warmupThe fix adds one line to match the behavior of
TwigExtension::load():Tests: Updated
TemplateIteratorTestto verify templates with the@!prefix are included.Verified: Fix was also tested on the original bug reproducer: https://github.com/mbessolov/twig-override-cache-reproducer