[Messenger] Incorrect filtering of signed messages based on Messenger routing #62807
+47
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orkin
force-pushed
the
fix/messenger-message-signature
branch
from
66ad353 to
c3b6d3f
Compare
|
|
||
| $container->getDefinition('messenger.signing_serializer') | ||
| ->replaceArgument(2, $messageToSerializersMapping); | ||
| $container->setParameter('messenger.message_to_serializers_mapping', $messageToSerializersMapping); |
Member
There was a problem hiding this comment.
why add this parameter? It's not needed for the fix isn't it?
better remove it IMHO
Orkin
force-pushed
the
fix/messenger-message-signature
branch
from
c3b6d3f to
ba73154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During compilation, messages that must be signed are correctly discovered from handler configuration.
However,
MessengerPasswas additionally filtering those messages usingMessengerrouting configuration viaarray_intersect_key.This behavior may rely on an intended coupling between routing and message signing (@nicolas-grekas ?), but routing configuration can contain wildcard patterns (e.g.
Some\Command\*) that do not correspond to concrete message class names.As a result, valid messages could be incorrectly excluded from the signing process.
This change removes the dependency on Messenger routing when determining which messages should be signed.
Message signing now relies solely on messages discovered at compile time, which is the only accurate source.