[Notifier][Prelude] Add bridge #62801
Conversation
OskarStark
changed the title
src/Symfony/Component/Notifier/Bridge/Prelude/Tests/PreludeTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
zairigimad
force-pushed
the
feat/prelude-notifier-sms
branch
from
ac3aed7 to
25486e5
Compare
I did fix the majority of comments, for UnsupportedSchemeException what should i update ? I will add the recipe asap |
zairigimad
force-pushed
the
feat/prelude-notifier-sms
branch
7 times, most recently
from
73600f2 to
3232eb7
Compare
zairigimad
force-pushed
the
feat/prelude-notifier-sms
branch
from
3232eb7 to
e439429
Compare
recipe done |
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
cool, thanks for submitting!
| 8.1 | ||
| --- | ||
|
|
||
| * Add bridge |
There was a problem hiding this comment.
| * Add bridge | |
| * Add bridge |
| "symfony/http-client": "^6.4|^7.0|^8.0", | ||
| "symfony/notifier": "^7.3|^8.0" | ||
| }, | ||
| "require-dev": { | ||
| "symfony/http-client": "^6.4|^7.0|^8.0" |
There was a problem hiding this comment.
| "symfony/http-client": "^6.4|^7.0|^8.0", | |
| "symfony/notifier": "^7.3|^8.0" | |
| }, | |
| "require-dev": { | |
| "symfony/http-client": "^6.4|^7.0|^8.0" | |
| "symfony/http-client": "^7.4|^8.0", | |
| "symfony/notifier": "^7.4|^8.0" |
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/9.3/phpunit.xsd" |
There was a problem hiding this comment.
11.3 now - please borrow from other bridges from branch 8.1
| private readonly ?string $scheduleAt = null, | ||
| private readonly ?string $callbackUrl = null, | ||
| private readonly ?string $correlationId = null, | ||
| private readonly ?string $preferredChannel = null, |
There was a problem hiding this comment.
We have quite some inconsistency in the way the various bridges define their options class.
The proposed one is very unlike the majority (eg things started with an $options argument and setters/getter without set/get prefixes.)
It's a bit inconsistent already, but let's define how we want to improve consistency? /cc @OskarStark
4 participants
This PR adds the support for Prelude Notification ( Prelude is a provider for OTP, Transactional SMS , and whatsapp messaging)
https://docs.prelude.so/introduction/welcome-to-prelude