Skip to content

[PropertyInfo] fix @var tag support for PhpStanExtractor #62713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Dec 10, 2025
Merged

[PropertyInfo] fix @var tag support for PhpStanExtractor #62713

nicolas-grekas merged 1 commit into from
Dec 10, 2025
+74 −4

Conversation

@qconer
Copy link
Contributor

@qconer qconer commented Dec 9, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #62712
License MIT

added fallback when no __construct PHPDocBlock exists

@qconer qconer requested a review from dunglas as a code owner December 9, 2025 17:47
@carsonbot carsonbot added this to the 7.4 milestone Dec 9, 2025
@qconer qconer mentioned this pull request Dec 9, 2025
Closed
@mtarld
Copy link
Contributor

mtarld commented Dec 9, 2025

Isn't this issue exist in 6.4 as well?

@qconer
Copy link
Contributor Author

qconer commented Dec 9, 2025

Isn't this issue exist in 6.4 as well?

Found this issue #62712 after updating from 6.4 to 7.4

@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2025

Isn't this issue exist in 6.4 as well?

Found this issue #62712 after updating from 6.4 to 7.4

Probably because you enabled the with_constructor_extractor option in 7.4? I guess the behaviour would still be wrong on lower versions if the constructor extractor was used.

@qconer
Copy link
Contributor Author

qconer commented Dec 10, 2025

Isn't this issue exist in 6.4 as well?

Found this issue #62712 after updating from 6.4 to 7.4

Probably because you enabled the with_constructor_extractor option in 7.4? I guess the behaviour would still be wrong on lower versions if the constructor extractor was used.

yes. works fine with disabled constructor extractors as I mentioned here #62712 (comment)

@OskarStark OskarStark changed the title [PropertyInfo] fix @var tag support for PhpStanExtractor [PropertyInfo] fix @var tag support for PhpStanExtractor Dec 10, 2025
@qconer
Copy link
Contributor Author

qconer commented Dec 10, 2025

should I prepare a separate PR with a fix for 6.4? It looks like the fix for 6.4 will conflict with this one

@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2025

should I prepare a separate PR with a fix for 6.4? It looks like the fix for 6.4 will conflict with this one

You can do that. We can then see if we can successfully resolve the conflicts when merging up (using this PR as a reference) or if we need to merge this PR then anyway).

@qconer qconer mentioned this pull request Dec 10, 2025
Merged
@qconer
Copy link
Contributor Author

qconer commented Dec 10, 2025

should I prepare a separate PR with a fix for 6.4? It looks like the fix for 6.4 will conflict with this one

You can do that. We can then see if we can successfully resolve the conflicts when merging up (using this PR as a reference) or if we need to merge this PR then anyway).

#62717

nicolas-grekas added a commit that referenced this pull request Dec 10, 2025
@nicolas-grekas
bug #62717 [PropertyInfo] fix @var tag support for `PhpStanExtrac…
491c2f4 
…tor` (qconer)

This PR was merged into the 6.4 branch.

Discussion
----------

[PropertyInfo] fix ``@var`` tag support for `PhpStanExtractor`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #62712
| License       | MIT

added fallback when no __construct PHPDocBlock exists

duplicate for #62713

Commits
-------

4158e3b fix: fix property info var tag extractor
symfony-splitter pushed a commit to symfony/property-info that referenced this pull request Dec 10, 2025
@nicolas-grekas
bug #62717 [PropertyInfo] fix @var tag support for `PhpStanExtrac…
ebac9fb 
…tor` (qconer)

This PR was merged into the 6.4 branch.

Discussion
----------

[PropertyInfo] fix ``@var`` tag support for `PhpStanExtractor`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #62712
| License       | MIT

added fallback when no __construct PHPDocBlock exists

duplicate for symfony/symfony#62713

Commits
-------

4158e3b37d1 fix: fix property info var tag extractor
@nicolas-grekas nicolas-grekas force-pushed the fix/fix-property-info-var-tag branch from 3e0d822 to 1f1dc46 Compare December 10, 2025 10:27
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 10, 2025

Thank you @qconer.

@nicolas-grekas nicolas-grekas merged commit 887d6a6 into symfony:7.4 Dec 10, 2025
6 checks passed
@xabbuh xabbuh mentioned this pull request Dec 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Bug PropertyInfo Status: Needs Review

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

5 participants

@qconer @mtarld @xabbuh @nicolas-grekas @carsonbot