[TwigBundle] Fix unintended BC break for the exception_controller twig setting
#62710
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
yceruto
reviewed
Dec 9, 2025
src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
stof
force-pushed
the
fix_twig_config_regression
branch
2 times, most recently
from
33f657a to
3189dae
Compare
yceruto
approved these changes
Dec 9, 2025
src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
stof
force-pushed
the
fix_twig_config_regression
branch
from
3189dae to
8819863
Compare
GromNaN
approved these changes
Dec 9, 2025
carsonbot
changed the title
GromNaN
changed the title
exception_controller twig setting
nicolas-grekas
approved these changes
Dec 9, 2025
src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
Setting this setting to `null` was the opt-in for the Symfony 5.0 behavior in TwigBundle and so was kept supported as a no-op in 5.0+ to support the migration path, without ever being deprecated. This setting was removed in 7.4.0 without deprecation, without realizing that it was part of this compat layer. This replaces this removal with a deprecation (reported as if it was introduced in 7.4 from the start) while the removal will be preserved in Symfony 8.0.
stof
force-pushed
the
fix_twig_config_regression
branch
from
8819863 to
683c79f
Compare
xabbuh
approved these changes
Dec 10, 2025
Member
|
Thank you @stof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
exception_controllersetting tonullwas the opt-in for the Symfony 5.0 behavior in TwigBundle 4.4 and so was kept supported as a no-op in 5.0+ to support the migration path, without ever being deprecated.This setting was removed in 7.4.0 without deprecation, without realizing that it was part of this compat layer. This replaces this removal with a deprecation (reported as if it was introduced in 7.4 from the start) while the removal will be preserved in Symfony 8.0.