[HttpClient] Fix ScopingHttpClient to always pass base_uri as string instead of parsed array
#62699
Conversation
santysisi
force-pushed
the
fix/ScopingHttpClient-baseuri
branch
3 times, most recently
from
b2e344c to
d2eec31
Compare
| if (\is_array($options['base_uri'] ?? null)) { | ||
| $options['base_uri'] = $this->unparseUrl($options['base_uri']); | ||
| } |
There was a problem hiding this comment.
I’m converting the URL back to a string because we currently allow passing base_uri as either a string or an array.
Ideally ( i think ), we should stop accepting arrays for base_uri, but removing that support in a patch or minor version would be a breaking change.
santysisi
force-pushed
the
fix/ScopingHttpClient-baseuri
branch
from
d2eec31 to
04ba787
Compare
|
status: needs work |
santysisi
force-pushed
the
fix/ScopingHttpClient-baseuri
branch
from
04ba787 to
165b263
Compare
|
status: needs review |
…ring` instead of parsed `array`
nicolas-grekas
force-pushed
the
fix/ScopingHttpClient-baseuri
branch
from
165b263 to
9f80dd4
Compare
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I went a little bit further and I'm now unsetting the option when resolving URLs.
The code was able to cope with a parsed array instead of a string, but this conflicted with RetryableHttpClient's expectation and was also not documented as a valid type for the option.
|
Thank you @santysisi. |
|
Thanks to both of you for fixing this 🙏 |
4 participants
Problem
ScopingHttpClientparsed thebase_uriinto anarray(scheme, path, query, etc.).RetryableHttpClient, it caused errors.HttpClientInterfacein Symfony Contracts,base_urimust be a stringSolution
ScopingHttpClientso it always forwardsbase_urias astring, not as a parsed array.RetryableHttpClient, since sending anarraywas not compliant with theHttpClientInterfacecomment.Additional Notes
Originally, the idea was to apply this fix only when the decorated client was
RetryableHttpClientand later add full support for parsedbase_uriforRetryableHttpClientin version 8.1.However, after reviewing the
HttpClientInterface, it became clear that sending a parsedarrayforbase_uriwas incorrect.Therefore, the behavior is now corrected universally.