[PropertyInfo] Fix PseudoType support in PhpDocTypeHelper #62684
+65
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
VincentLanglet
force-pushed
the
failing/62636
branch
from
83962c1 to
701f4e3
Compare
VincentLanglet
changed the title
Contributor
Author
|
Milestone should be edited to 7.3 @OskarStark. Also I dunno how you want to handle this fix since the PR from 6.4 (#62686) will create conflict, so I opened the fix on 7.3 too to show the expected resutl. |
mtarld
approved these changes
Dec 8, 2025
xabbuh
approved these changes
Dec 8, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2025
…(VincentLanglet) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [PropertyInfo] Fix PseudoType support in PhpDocTypeHelper | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62636 | License | MIT The PR on 7.3 is #62684 I'm not sure how you want to deal with the merges since there will be conflict when merging up 6.4 into 7.3 so I opened both PR to show the changes Commits ------- e2b7844 [PropertyInfo] Fix PseudoType support in PhpDocTypeHelper
nicolas-grekas
force-pushed
the
failing/62636
branch
from
466a268 to
9dd5cdb
Compare
Member
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR on 6.4 is #62686
I'm not sure how you want to deal with the merges since there will be conflict when merging up 6.4 into 7.3 so I opened both PR to show the changes