[DependencyInjection] Allow manual bindings on parameters with #[Target] #62477
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I added this because there is a competition between bindings and autowiring for |
yoeunes
force-pushed
the
di-allow-binding-on-target
branch
from
a9938cb to
8b68505
Compare
yoeunes
force-pushed
the
di-allow-binding-on-target
branch
from
8b68505 to
6fb5c67
Compare
Contributor
Author
|
Hi @nicolas-grekas, I updated the logic as suggested to handle both cases:
I added a test case covering both scenarios. |
nicolas-grekas
approved these changes
Nov 24, 2025
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #60910 added a check in
ResolveBindingsPassthat skips parameters with the#[Target]attribute.This prevents users from manually overriding values via
bind(or_defaults) and causes"unused binding"exceptions, even when the binding matches the parameter name.Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: A binding is configured for an argument named "$arg" for service "service", but no corresponding argument has been found. It may be unused and should be removed, or it may have a typo.