-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[DependencyInjection] Deprecate default index/priority methods when defining tagged locators/iterators #62339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.1
Are you sure you want to change the base?
[DependencyInjection] Deprecate default index/priority methods when defining tagged locators/iterators #62339
Conversation
src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php
Outdated
Show resolved
Hide resolved
2677a0a to
9b40d76
Compare
|
Status: needs work The last commit fixes the tests but needs close review / refactoring of mine (it's LLM generated for now) |
|
I don't think the amount of code simplification brought by that feature is worth adding new deprecations so late in the process. |
9b40d76 to
b38d2ae
Compare
…efining tagged locators/iterators
b38d2ae to
b2a8a19
Compare
|
PR rebased to target 8.1 We could also deprecate Status: needs review |
|
@nicolas-grekas those are doing separate things. |
|
@stof I get what you mean. What about the current PR? 👍 ? :) |
The is deprecating
getDefaultFooName()methods and$defaultIndexMethodarguments used to build tagged iterators/locators (and alike for priorities).These have been supersceded by
#[AsTaggedItem]attributes, which are available since Symfony 5.3.It was about time. Deprecating these will reduce complexity of the code, and of the doc!
We could also deprecate
#[AsTaggedItem]in favor of#[AutoconfigureTag]at some point but this needs dedicated thoughts.See #48532 for some background on this idea.