Skip to content

Conversation

@nicolas-grekas
Copy link
Member

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues https://github.com/symfony/symfony/pull/61182/files#r2500627687
License MIT

Looks like the bump was too aggressive.

@carsonbot carsonbot added this to the 8.0 milestone Nov 7, 2025
@nicolas-grekas nicolas-grekas changed the title [Translation] Relax version constrainst for contracts [Translation] Relax version constraint for contracts Nov 7, 2025
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the low deps failure looks related

@stof
Copy link
Member

stof commented Nov 7, 2025

I think we need to require ^3.6.0 because older versions don't support PHPUnit 10+ in their test cases (that's the reason for all the failures about missing arguments, as PHPUnit 11 does not support @dataProvider annotations anymore).

and for the test failing for TranslatableInterface in the global parameters, I think it might be a legitimate reason to use 3.6.1 as lowest bound to have that fix available: symfony/translation-contracts@3a74934
But this means we need to release that fix.

@xabbuh
Copy link
Member

xabbuh commented Nov 7, 2025

I had a deeper look. For PHPUnit 12 compatibility we need #58182 (released in 3.6.0). For the then remaining test failure we need #61111 which isn't released yet.

@nicolas-grekas
Copy link
Member Author

Ah, OK, we need #61111 on 8.0

@nicolas-grekas nicolas-grekas deleted the tr-ctrct branch November 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants