[DependencyInjection] Fix repeatable #[AsTaggedItem] to avoid double registration and ignoring container.ignore_attributes
#62327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e registration and ignoring `container.ignore_attributes`
stof
reviewed
Nov 6, 2025
| $reflector = null !== $class ? $container->getReflectionClass($class) : null; | ||
| $checkTaggedItem = !$definition->hasTag($definition->isAutoconfigured() ? 'container.ignore_attributes' : $tagName); | ||
|
|
||
| foreach ($attributes as $attribute) { |
Member
There was a problem hiding this comment.
This loop is about looping over the various tags added explicitly in the service definition. Anything that skips this loop is broken by design. Explicit tag attributes must win over the AsTaggedItem attribute providing autoconfigured fallback values (see the priority of values in PriorityTaggedServiceUtil::getDefault())
Member
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2025
…ggeditem] (nicolas-grekas) This PR was merged into the 7.3 branch. Discussion ---------- [DependencyInjection] Fix merging explicit tags and #[AsTaggeditem] | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59088 (comment) | License | MIT Instead of #62327 Commits ------- e31b192 [DependencyInjection] Fix merging explicit tags and #[AsTaggeditem]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More reviewable without whitespaces