[Twig] Ensure WrappedTemplatedEmail::getReturnPath() returns a string #62297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoeunes
force-pushed
the
twig-wrapped-email-return-type
branch
3 times, most recently
from
6f2b3a3 to
8eed792
Compare
Member
|
This fix is still incomplete, as you now return |
yoeunes
force-pushed
the
twig-wrapped-email-return-type
branch
from
8eed792 to
d5d59e0
Compare
Contributor
Author
|
Hi @stof thank you, fixed now |
Member
|
Let's add a test case? I suppose the current code (before this change) throws an exception? |
yoeunes
force-pushed
the
twig-wrapped-email-return-type
branch
from
d5d59e0 to
f3a763e
Compare
yoeunes
force-pushed
the
twig-wrapped-email-return-type
branch
from
f3a763e to
39c70bb
Compare
Contributor
Author
|
Hi @nicolas-grekas, thanks for the review. I didn't test this at runtime. I found it because You're right, it would likely cause a fatal |
Member
|
Thank you @yoeunes. |
This was referenced Nov 6, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a return type error in
WrappedTemplatedEmail::getReturnPath().The method is type-hinted to return a
string, but it was directly returning the result of$this->message->getReturnPath(), which is?Address.