[HtmlSanitizer] Remove srcdoc from allowed attributes
#62201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
Oct 29, 2025
src/Symfony/Component/HtmlSanitizer/Tests/HtmlSanitizerAllTest.php
Outdated
Show resolved
Hide resolved
The `srcdoc` attribute is unlisted from the standard attributes to prevent potential misconfiguration.
It must now be explicitly enabled, and it is STRONGLY advised to `->forceAttribute('iframe', 'sandbox', '')` when doing so.
A new test ensures that `<iframe>` elements with unsafe attributes, including `srcdoc`, are sanitized correctly.
nicolas-grekas
force-pushed
the
sanitizer-safer
branch
from
e8890a4 to
03fa754
Compare
mtarld
approved these changes
Oct 29, 2025
fabpot
approved these changes
Oct 29, 2025
Member
|
Thank you @nicolas-grekas. |
This was referenced Nov 2, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
srcdocattribute is unlisted from the standard attributes to prevent potential misconfiguration. It must now be explicitly enabled, and it is STRONGLY advised to->forceAttribute('iframe', 'sandbox', '')when doing so.Submitting as a bugfix because the current defaults are a foot-gun.