Skip to content

[JsonStreamer] Add deprecation related tests #62160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexandre-daubois merged 1 commit into from
Oct 25, 2025
Merged

[JsonStreamer] Add deprecation related tests #62160

alexandre-daubois merged 1 commit into from
Oct 25, 2025

Conversation

@mtarld
Copy link
Contributor

@mtarld mtarld commented Oct 25, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

As mentionned in #62159 (review)

@carsonbot carsonbot added this to the 7.4 milestone Oct 25, 2025
@alexandre-daubois alexandre-daubois self-requested a review October 25, 2025 09:32
alexandre-daubois
alexandre-daubois requested changes Oct 25, 2025
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are related it seems

@mtarld mtarld force-pushed the minor/json-streamer-deprecation-test branch from c1093c1 to dfe3a49 Compare October 25, 2025 09:37
@mtarld mtarld force-pushed the minor/json-streamer-deprecation-test branch from dfe3a49 to da24c13 Compare October 25, 2025 09:39
@mtarld
Copy link
Contributor Author

mtarld commented Oct 25, 2025

@alexandre-daubois, the failures were not related to that PR, but rather to #62158.
Now that it has been merged, it should be back to green!

@alexandre-daubois
Copy link
Member

alexandre-daubois commented Oct 25, 2025

Thank you @mtarld.

@alexandre-daubois alexandre-daubois merged commit 8128f1a into symfony:7.4 Oct 25, 2025
11 of 12 checks passed
@mtarld mtarld deleted the minor/json-streamer-deprecation-test branch October 25, 2025 10:08
GromNaN added a commit to mtarld/symfony that referenced this pull request Oct 25, 2025
@GromNaN
Revert "minor symfony#62160 [JsonStreamer] Add deprecation related te…
37495df 
…sts (mtarld)"

This reverts commit 8128f1a, reversing
changes made to 741f21c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

JsonStreamer Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

5 participants

@mtarld @alexandre-daubois @GromNaN @chalasr @carsonbot