[JsonStreamer] Remove deprecated code #62159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Oct 25, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
I'm surprised that there is no need to modify or delete tests, so this feature was not tested in 7.4.
mtarld
force-pushed
the
minor/json-streamer-remove-deprecations
branch
from
5a333a9 to
1620e5d
Compare
Contributor
Author
|
Indeed, @GromNaN, tests are missing for that, I'm going to add them ASAP. |
mtarld
force-pushed
the
minor/json-streamer-remove-deprecations
branch
from
1620e5d to
fe6219a
Compare
alexandre-daubois
added a commit
that referenced
this pull request
Oct 25, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [JsonStreamer] Add deprecation related tests | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT As mentionned in #62159 (review) Commits ------- da24c13 [JsonStreamer] Add deprecation related tests
GromNaN
force-pushed
the
minor/json-streamer-remove-deprecations
branch
from
fe6219a to
37495df
Compare
GromNaN
approved these changes
Oct 25, 2025
Member
|
@mtarld I rebased your branch and reverted the commit adding tests in 7.4 |
nicolas-grekas
force-pushed
the
minor/json-streamer-remove-deprecations
branch
from
37495df to
9bdf13e
Compare
Member
|
Thank you @mtarld. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated code from
JsonStreamer.