[Mailer] Fix parsing message ids in SMTP responses #62145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3 for bug fixes". Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
nicolas-grekas
changed the title
Member
|
Thank you @hacfi. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2025
This PR was submitted for the 7.3 branch but it was merged into the 6.4 branch instead. Discussion ---------- [Mailer] Fix parsing message ids in SMTP responses | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT I noticed that the message id from Sendgrid didn't get always parsed properly. Looking into the issue I found that sometimes the format looks like `UM1N3y_WXg6h51oIppcERg` or `X8P9ZIaiT3653-UXj4ljGX` which isn't matched by the current regex at https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php#L159-L160 This PR fixes matching all Sendgrid ids. Commits ------- f2a254e [Mailer] Fix parsing message ids in SMTP responses
Member
|
Merged as 385cea7 on branch 6.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the message id from Sendgrid didn't get always parsed properly. Looking into the issue I found that sometimes the format looks like
UM1N3y_WXg6h51oIppcERgorX8P9ZIaiT3653-UXj4ljGXwhich isn't matched by the current regex at https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php#L159-L160This PR fixes matching all Sendgrid ids.