[DependencyInjection] Fix FC with Config v8 #62138
Conversation
| if (\is_bool($generator)) { | ||
| $prepend = $generator; | ||
| $generator = null; | ||
| } |
There was a problem hiding this comment.
should we trigger a deprecation in the else branch ?
There was a problem hiding this comment.
The issue is that we should still support config builders, so we'd always trigger that one (unless we go with an extra silencing argument, but as I wrote the other comment, this might be good enough in practice.)
There was a problem hiding this comment.
We can trigger a deprecation in 8.1
| $container->registerExtension(new \AcmeExtension()); | ||
| $container->prependExtensionConfig('acme', ['foo' => 'bar']); | ||
| $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures/config'), 'prod', new ConfigBuilderGenerator(sys_get_temp_dir()), true); | ||
| $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures/config'), 'prod', prepend: true); |
There was a problem hiding this comment.
Tests should not use named parameters. This hides unintentional BC breaks that would be detected due to tests being forced to be updated, by making tests used the public API.
There was a problem hiding this comment.
Yeah, I did a quick FC layer, that's true :)
I think all this is confidential enough to make it this way.
We can always improve later on.
4 participants
Required for #62113