[Console] Ensure SHELL_VERBOSITY is always restored properly
#62058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttskch
changed the title
SHELL_VERBOSITY is always restored properlySHELL_VERBOSITY is always restored properly
ttskch
force-pushed
the
fix/console-shell-verbosity
branch
2 times, most recently
from
39d8a5c to
cb18974
Compare
xabbuh
reviewed
Oct 14, 2025
nicolas-grekas
force-pushed
the
fix/console-shell-verbosity
branch
from
cb18974 to
8da524e
Compare
nicolas-grekas
approved these changes
Oct 14, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I implemented the 3 separate resets and did some code simplifications while at it.
Member
|
Thank you @ttskch. |
Contributor
|
Hi @ttskch, Just for information, I had an issue with PestPHP because I didn't have any output anymore when I launched my tests. It is because with the default configuration of PHPUnit as you mentioned, the Now, I need to remove the server superglobal variable Maybe it is good to fix it like it but it can generate behavior change, or maybe I miss something 😄 Regards, Mickaël |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where if only
$_SERVER['SHELL_VERBOSITY']or$_ENV['SHELL_VERBOSITY']had a value, they would be erroneously unset after command execution.For example, in PHPUnit's default configuration,
SHELL_VERBOSITYis set only to$_SERVER['SHELL_VERBOSITY'].This caused the
SHELL_VERBOSITYsetting to be invalid after a console command was executed internally using theResetDatabasetrait of zenstruck/foundry.