[Translation][Loco] filter should be empty when filtering on all domains #62038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiix
force-pushed
the
loco-all-domains
branch
4 times, most recently
from
77d9a93 to
8974bb6
Compare
nicolas-grekas
requested review from
OskarStark,
chalasr,
dunglas,
jderusse,
lyrixx,
xabbuh and
yceruto
as code owners
nicolas-grekas
force-pushed
the
loco-all-domains
branch
from
8974bb6 to
e11c9aa
Compare
Member
|
Thank you @atomiix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling translations for all domains (
*), thefilterquery parameter value is set to*but that filters only translations that do have at least one tag.Using an empty value for
filterfetches also translations that don’t have any tag.