[DoctrineBridge] Deprecate AbstractDoctrineExtension
#61992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
AbstractDoctrineExtensionAbstractDoctrineExtension
GromNaN
force-pushed
the
doctrine-abstract
branch
2 times, most recently
from
e937616 to
5b8695c
Compare
alexandre-daubois
approved these changes
Oct 8, 2025
src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
Outdated
Show resolved
Hide resolved
GromNaN
commented
Oct 8, 2025
| /** | ||
| * @author Fabio B. Silva <[email protected]> | ||
| */ | ||
| #[IgnoreDeprecations] |
Member
Author
There was a problem hiding this comment.
We can specify which deprecation message is ignored: sebastianbergmann/phpunit#6341
Member
There was a problem hiding this comment.
No we cannot. Our CI uses PHPUnit 11.4. The PR you linked is part of PHPUnit 12.4 (which requires PHP 8.4+)
xabbuh
approved these changes
Oct 8, 2025
nicolas-grekas
force-pushed
the
doctrine-abstract
branch
from
4049eba to
4115211
Compare
Member
|
Thank you @GromNaN. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 8, 2025
…romNaN) This PR was squashed before being merged into the 8.0 branch. Discussion ---------- [DoctrineBridge] Remove `AbstractDoctrineExtension` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Follows #61992 | License | MIT Commits ------- 00b19ad [DoctrineBridge] Remove `AbstractDoctrineExtension`
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AbstractDoctrineExtensionis only used byDoctrineBundleandDoctrineMongoDBODMBundle. It's not used directly by applications.Having this abstract class makes changing the configuration structure complex. In order to ease maintenance and evolution, the class is inlined into bundle's extension classes.
DoctrineBundle: Inline parent class code doctrine/DoctrineBundle#2076DoctrineMongoDBBundle: InlineAbstractDoctrineExtensionfrom Symfony Doctrine bridge doctrine/DoctrineMongoDBBundle#923