[FrameworkBundle] fix using lock from service id when previous locks used env vars #61939
Conversation
nicolas-grekas
requested review from
OskarStark,
chalasr,
dunglas,
jderusse,
lyrixx,
xabbuh and
yceruto
as code owners
nicolas-grekas
force-pushed
the
lock-from-service-fix
branch
2 times, most recently
from
44e7ddc to
fcfd9a7
Compare
|
@nicolas-grekas I guess this test doesn't work because that feature was only added in 7.2, would you like me to do something or are you taking care? |
|
I'd be happy if you could have a look. To me, the issue exists on 6.4, even if it might manifest itself differently. That's why I rebased on 6.4. Thanks! |
|
@nicolas-grekas we could certainly apply the fix to 6.4, but since the result of Only in 7.2 where the new if condition is added can we use my test. |
|
OK, let's go with 7.3 then, sorry for the bad push. Can you reset --hard to that previous commit of yours and push+retarget again? |
AydinHassan
force-pushed
the
lock-from-service-fix
branch
from
fcfd9a7 to
0cf7a9a
Compare
|
no problem! and done :) |
|
Thank you @AydinHassan. |
3 participants
When specifying multiple locks including one which references a service id, and a previous one used an env var, the service id is not converted in to a reference. This is because
usedEnvsis not reset in the loop and is passed by reference. Not sure if this is intentional or not but it looks like a mistake to me. A similar reset is done here.