[DependencyInjection][Routing] Remove support for the XML configuration format #61930
Conversation
nicolas-grekas
force-pushed
the
drop-xml-config
branch
2 times, most recently
from
1298bce to
bc43f76
Compare
| $locatorPass = new ServiceLocatorTagPass(); | ||
| $locatorPass->process($container); | ||
| } | ||
| $dumpedContainer = unserialize(file_get_contents(substr_replace($file, '.ser', -4))); |
There was a problem hiding this comment.
I suggest changing the value of debug.container.dump to have a file name ending in .ser directly instead of keeping a .xml path while the XML file won't exist.
There was a problem hiding this comment.
I'd keep the param as is: the xml file still exists and is dumped e.g. for IDE plugins
…ML loaders are removed (nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- Ensure branch 7.4 will remain compatible with 8.0 once XML loaders are removed | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After #60568 Needed for #61930 Commits ------- 758c7f5 Ensure branch 7.4 will remain compatible with 8.0 once XML loaders are removed
nicolas-grekas
force-pushed
the
drop-xml-config
branch
from
bc43f76 to
af1f030
Compare
|
PR ready, failures unrelated |
|
does this also include the removal of var/cache/env/*Container.xml? |
|
It doesn't (see #61930 (comment)) |
|
so IIUC we preserve XML format on that location for the future? |
|
Correct, see #61280 |
|
im struggling why we couldnt maintain the format then for every day config, personally i dont mind lack of xsd valition nor requiring ext-dom (in userland) |
|
The discussion happened in #60568 |
|
|
This is really not helping @ro0NL, please do your part, this is burning my good will. |
|
perhaps, but enforcing a full format migration like that, is not what i was waiting for |
|
we have 3 years of hoping the migration tool will do it's job, so OK. |
|
Thank you @nicolas-grekas. |
6 participants
Per #60568