[Serializer] xml empty array encoding #61882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
xml-encoder-preserve-key-breaks
branch
from
9b30112 to
f7be1cc
Compare
soyuka
force-pushed
the
xml-encoder-preserve-key-breaks
branch
from
f7be1cc to
be51e2c
Compare
Member
|
Thank you @soyuka. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a BC break introduced in #60228.
At https://github.com/symfony/symfony/pull/60228/files#diff-b031dbb2186367839adfe20696612866da91513dd315f00ad6df23b5d38fca74R381 the condition change breaks encoding of an empty array:
Indeed,
array_find_keyon an empty array correctly finds no string keys and returns null, making the condition true. The previous version usingctype_digitwas false.