[Uid] Use Interfaces for Factories #61842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hanmac
commented
Sep 25, 2025
Hanmac
commented
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #61807 (comment) |
| License | MIT |
Member
|
Introducing such interfaces without updating the id generators of the doctrine-bridge to accept them will not allow using the mock factories |
Contributor
Author
|
@stof updated the Generator in Doctrine |
OskarStark
reviewed
Sep 25, 2025
| $ulid = new Ulid('00000000000000000000000000'); | ||
| $em = (new \ReflectionClass(EntityManager::class))->newInstanceWithoutConstructor(); | ||
| $factory = $this->createMock(UlidFactory::class); | ||
| $factory = $this->createMock(UlidFactoryInterface::class); |
Contributor
There was a problem hiding this comment.
Can't we use the mockfactory here?
Contributor
Author
There was a problem hiding this comment.
Maybe? Can you link me an example?
Member
|
I'm rather 👎 : that's introducing yet more abstractions for not real benefits. |
Member
|
I agree with @nicolas-grekas. Thank you for proposing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.