[AssetMapper] Prevent duplicate entries in module preloads #61793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
xDeSwa
changed the title
Member
|
Is that something happening in basic cases ? I'm not experiencing it locally, would you have any reproducer or (a bit) more detailed explanation on "when" that would happen ? |
Contributor
Author
|
Comment on lines
76
to
78
| if (!in_array($path, $modulePreloads, true)) { | ||
| $modulePreloads[] = $path; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!in_array($path, $modulePreloads, true)) { | |
| $modulePreloads[] = $path; | |
| } | |
| $modulePreloads[$path] = $path; |
Member
|
Thank you @xDeSwa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a library in
assets/controllers.jsonis configured with"eager(ex. live-component when eager),it may result in duplicate
modulepreloadentries being generated.This change ensures that each preload path is only added once, even if the same import
appears multiple times. It also prevents accidental duplication in
importmap.phpifa library is mistakenly listed more than once.