Skip to content

[Mailer][Mandrill] Add subaccount to the payload #61775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Sep 19, 2025
Merged

[Mailer][Mandrill] Add subaccount to the payload #61775

fabpot merged 1 commit into from
Sep 19, 2025

Conversation

@andrehoong-pixieset
Copy link
Contributor

@andrehoong-pixieset andrehoong-pixieset commented Sep 16, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues N/A
License MIT

@carsonbot carsonbot added this to the 7.4 milestone Sep 16, 2025
@carsonbot
Copy link

carsonbot commented Sep 16, 2025

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Add the subaccount paramater to the MandrillApiTransport payload Add the subaccount paramater to the MandrillApiTransport payload Sep 16, 2025
@carsonbot carsonbot changed the title Add the subaccount paramater to the MandrillApiTransport payload [Mailer] Add the subaccount paramater to the MandrillApiTransport payload Sep 17, 2025
@OskarStark OskarStark changed the title [Mailer] Add the subaccount paramater to the MandrillApiTransport payload [Mailer][Mandrill] Add the subaccount paramater to the payload Sep 17, 2025
@OskarStark OskarStark changed the title [Mailer][Mandrill] Add the subaccount paramater to the payload [Mailer][Mandrill] Add subaccount to the payload Sep 17, 2025
@OskarStark
Copy link
Contributor

OskarStark commented Sep 17, 2025

Can you please add a test case? Thanks

@andrehoong-pixieset andrehoong-pixieset force-pushed the add-subaccount-to-mandrill-api-transport-payload branch from 713055f to 4c85200 Compare September 17, 2025 16:31
@andrehoong-pixieset
Copy link
Contributor Author

andrehoong-pixieset commented Sep 17, 2025

Hey @OskarStark a unit test has been added to cover this!

stof
stof requested changes Sep 17, 2025
View reviewed changes
@fabpot fabpot force-pushed the add-subaccount-to-mandrill-api-transport-payload branch from 0f8c7bc to f5b2050 Compare September 19, 2025 10:30
@fabpot
Copy link
Member

fabpot commented Sep 19, 2025

Thank you @andrehoong-pixieset.

@fabpot fabpot merged commit 91f8966 into symfony:7.4 Sep 19, 2025
10 of 12 checks passed
@fabpot fabpot mentioned this pull request Sep 19, 2025
Closed
@fabpot fabpot mentioned this pull request Oct 27, 2025
Merged
@fabpot fabpot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees

No one assigned

Labels

Feature Mailer Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

6 participants

@andrehoong-pixieset @carsonbot @OskarStark @fabpot @stof @xabbuh