-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[TypeInfo] Add result cache to TypeContextFactory
#61765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:7.4
from
landure:61725-type-context-factory-caching
Sep 17, 2025
Merged
[TypeInfo] Add result cache to TypeContextFactory
#61765
fabpot
merged 1 commit into
symfony:7.4
from
landure:61725-type-context-factory-caching
Sep 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Sep 16, 2025
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
TypeContextFactory
8a9f8b5 to
a29f10b
Compare
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/TypeInfo/TypeContext/TypeContextFactory.php
Outdated
Show resolved
Hide resolved
defb034 to
cb47384
Compare
nicolas-grekas
approved these changes
Sep 16, 2025
fabpot
approved these changes
Sep 17, 2025
Member
fabpot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 7.4 as this is a performance improvement.
Add a cache to method with the aims to optimize deserialization and form validation. Closes symfony#61725
cb47384 to
e39963f
Compare
Member
|
Thank you @landure. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add caches to
TypeContextFactorymethod to prevent multiple parsing of the same classes by PHPStan property extractor.Add cache to intermediate
TypeContextcreation fromcreateFromClassName()andcreateFromReflection()by adding:intermediateTypeContextCacheproprety.createIntermediateTypeContext()create the intermediateTypeContextif not found in cache.Add cache to
createFromClassName()by:typeContextCacheproprety.TypeContextcreation to privatecreateNewInstanceFromClassName()method.createFromClassName()to get theTypeContextfrom$this->typeContextCache, or creating it by callingcreateNewInstanceFromClassName()method.Add a test to check that the results are cached.
This optimize deserialization and form validation.