[Mailer][Sendgrid] Add support for global region
#61758
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| parent::__construct(null !== $region ? \sprintf('smtp.%s.sendgrid.net', $region) : 'smtp.sendgrid.net', 465, true, $dispatcher, $logger); | ||
| $host = 'smtp.sendgrid.net'; | ||
|
|
||
| if (null !== $region && 'global' !== strtolower($region)) { |
There was a problem hiding this comment.
| if (null !== $region && 'global' !== strtolower($region)) { | |
| if (null !== $region && 'global' !== $region) { |
I don't think we need to make it case insensitive.
fabpot
force-pushed
the
61706-sendgrid-global-region
branch
from
ddb96be to
9ce7d5d
Compare
|
Thank you @sonnymilton. |
|
Hi @sonnymilton, thank you for providing a fix to #61706! Did you also check the |
…ansport) (sonnymilton) This PR was merged into the 7.4 branch. Discussion ---------- [Mailer][Sendgrid] Add support for `global` region (api transport) | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #61706 | License | MIT Related to #61706 and #61758 Add support for `global` region (`SendgridApiTransport`) Commits ------- 8eb5a45 [Mailer][Sendgrid] Add support for `global` region (api transport)
4 participants
This PR ensures that when the
globalregion is provided toSendgridSmtpTransport,the correct host
smtp.sendgrid.netis used.Previously, passing
region=globalresulted in the host being built assmtp.global.sendgrid.net, which does not exist.Why
sendgrid+smtp://KEY@default?region=globalfailed to connect.smtp.sendgrid.net(same as when no region is provided).
How
SendgridSmtpTransportto special-case theglobalregion.