[Console] Command: Add addOptionWithValue() #61665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrana
force-pushed
the
addOptionWithValue
branch
3 times, most recently
from
f036b81 to
373bb7d
Compare
vrana
requested review from
lyrixx,
welcoMattic,
xabbuh and
yceruto
as code owners
vrana
force-pushed
the
addOptionWithValue
branch
from
1da295d to
2491e57
Compare
GromNaN
requested changes
Sep 6, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
This feature seems redundant with the possibility of using a BackedEnum type with invokable commands. #60586
Also, you cannot use a new features of a component directly in other components without changing the required version in all their composer.json files. But we avoid adding constraints in minor versions as much as possible. This feature does not justify it here. Changing this could only be done in 8.0. But let's discuss the feature itself before looking at how it is used in Symfony commands.
vrana
force-pushed
the
addOptionWithValue
branch
2 times, most recently
from
55624d7 to
b81a3a0
Compare
Contributor
Author
|
This is much simpler to use. I've dropped the commit using it in the existing code. Here it is if someone wants to take a look: 55624d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add an option with one of allowed values. To do that, I needed to check the argument validity, format help and set suggested values. This PR encapsulates it in a function.