[Serializer] Fix dealing with asymmetric visilibity for properties #61571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
fix/serializer-asymmetric-visibility-error
branch
3 times, most recently
from
559a53e to
a91d37e
Compare
santysisi
changed the title
protected(set) propertiesprotected(set) or private(set) properties
Contributor
Author
|
I think (though I might be wrong) that the pipeline errors are not relevant in the context of this PR. |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
thanks for opening this!
src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
Outdated
Show resolved
Hide resolved
santysisi
force-pushed
the
fix/serializer-asymmetric-visibility-error
branch
from
a91d37e to
7407d03
Compare
Contributor
Author
|
Hi 😊 I hope you're doing well! |
src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
Outdated
Show resolved
Hide resolved
santysisi
force-pushed
the
fix/serializer-asymmetric-visibility-error
branch
from
7407d03 to
81f3a04
Compare
Contributor
Author
Thanks for pointing that out! Maybe I’m wrong, but I think it might not be necessary to update the call to |
nicolas-grekas
changed the title
protected(set) or private(set) properties
…otected(set)` properties
nicolas-grekas
force-pushed
the
fix/serializer-asymmetric-visibility-error
branch
from
81f3a04 to
6310c44
Compare
Member
|
Thank you @santysisi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a crash in the
Serializerwhen deserializing an object with aprotected(set)orprivate(set)property