[DependencyInjection][Routing] Add JSON schema for validating and autocompleting YAML config files #61282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
GromNaN
reviewed
Jul 31, 2025
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
Contributor
|
Little bit off topic, but what do you think about a JsonSchema component? we could also reuse this in symfony/ai |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
not mine to write, that typically the kind of stuff I'd rather outsource to another lib |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
HypeMC
reviewed
Aug 7, 2025
Member
HypeMC
left a comment
HypeMC
left a comment
There was a problem hiding this comment.
I've noticed a few issues while testing.
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.schema.json
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
json-schema
branch
from
84382b0 to
0aaba40
Compare
Member
Author
|
PR updated. |
…ocompleting YAML config files
nicolas-grekas
force-pushed
the
json-schema
branch
from
0aaba40 to
f535cc6
Compare
alexandre-daubois
approved these changes
Aug 21, 2025
This was referenced Aug 21, 2025
fabpot
approved these changes
Aug 22, 2025
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2025
… and autocompleting YAML config files (nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [Serializer][Validator] Add JSON schema for validating and autocompleting YAML config files | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Same as #61282 but for serialization and validation metadata. This provides autocompletion/validation on IDEs that support JSON schema for YAML files, such as phpStorm. We need to remember updating the serialization schema when context builders are updated. Commits ------- f3ff89a [Serializer][Validator] Add JSON schema for validating and autocompleting YAML config files
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59620
This provides autocompletion/validation on IDEs that support JSON schema for YAML files, such as phpStorm.
Note that this cannot support yaml tags, so no autocompletion after
!servicefor example.The only way to provide this would be to ship a language server. Out of reach I fear.
Recipe update at symfony/recipes#1447