-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Messenger] Firebird Database - incompatibility with expected lowercase columns #61232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger] Firebird Database - incompatibility with expected lowercase columns #61232
Conversation
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
|
Are you using the connection for the messenger exclusively? If so, you could use DBAL's portability middleware to control the casing of result columns. |
Why would you be unable to use |
You’re right — I can use instanceof. My initial concern was a potential fatal if the class wasn’t available. I will updated the PR. |
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derrabus wrote this:
Are you using the connection for the messenger exclusively? If so, you could use DBAL's portability middleware to control the casing of result columns.
WDYT of this proposal? Applicable?
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
Unfortunately not applicable here — the Doctrine connection is shared, not Messenger‑exclusive. |
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
b2bdbc8 to
6223362
Compare
|
Thank you @DSsatwareAG. |
Firebird Database - incompatibility with expected lowercase columns
Fix ensures, for Firebird databases, the column names are consistently converted to lowercase before being processed by Doctrine Messenger. This resolves the incompatibility by providing Messenger with the expected lowercase column names, regardless of how Firebird returns them.
Because the FirebirdPlatform is not part of the doctrine/dbal package, I was unable to use instanceof for platform detection. Instead, I implemented a string comparison to check for Firebird as the database platform.