[Translation] Remove TranslatableMessage::__toString() method, use trans() or getMessage() instead
#61182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 21, 2025
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | - |
| License | MIT |
stof
reviewed
Jul 21, 2025
nicolas-grekas
changed the title
TranslatableMessage::__toString() method, use trans() insteadTranslatableMessage::__toString() method, use trans() or getMessage() instead
nicolas-grekas
force-pushed
the
tr-drop-tostring
branch
from
9aa04d4 to
5d7fd4a
Compare
alexandre-daubois
approved these changes
Jul 21, 2025
nicolas-grekas
force-pushed
the
tr-drop-tostring
branch
3 times, most recently
from
abd264e to
a2f31e4
Compare
…`trans()` or `getMessage()` instead
nicolas-grekas
force-pushed
the
tr-drop-tostring
branch
from
a2f31e4 to
6f68b45
Compare
Merged
| "php": ">=8.4", | ||
| "symfony/polyfill-mbstring": "^1.0", | ||
| "symfony/translation-contracts": "^2.5|^3.0" | ||
| "symfony/translation-contracts": "^3.6.1" |
Contributor
There was a problem hiding this comment.
There is currently no 3.6.1 tag of symfony/translation-contracts.
https://github.com/symfony/translation-contracts/tags
This lead to the error
Problem 1
- Root composer.json requires symfony/translation ^5.4 || ^6.4 || ^7.0 || ^8.0 -> satisfiable by symfony/translation[v8.0.0-BETA1].
- symfony/translation v8.0.0-BETA1 requires symfony/translation-contracts ^3.6.1 -> found symfony/translation-contracts[dev-main, 3.6.x-dev (alias of dev-main)] but it does not match your minimum-stability.
when trying to support 8.0 ; would it be possible to create a new tag or relax the condition ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.