[DoctrineBridge] Fix UniqueEntityValidator for fields (simple_array, json, ONE_TO_MANY ,MANY_TO_MANY) #61129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkania
force-pushed
the
unique-entity-all-types
branch
from
93b2d73 to
761df8d
Compare
wkania
force-pushed
the
unique-entity-all-types
branch
2 times, most recently
from
11a8ac5 to
2b1a80e
Compare
…json, ONE_TO_MANY ,MANY_TO_MANY)
wkania
force-pushed
the
unique-entity-all-types
branch
from
2b1a80e to
636699a
Compare
Contributor
Author
|
This should be more DX then a bug. |
stof
reviewed
Sep 17, 2025
| $this->assertCount(1, $this->context->getViolations()); | ||
| } | ||
|
|
||
| #[IgnoreDeprecations] |
Member
There was a problem hiding this comment.
Why making this a legacy test ? Is this testing a deprecated behavior ? Would it be a test that we delete in 8.0 ?
Adding new legacy tests is quite suspicious for a PR that does not introduce any new deprecations.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the validator does not work with fields of type
simple_array,json, or with associations likeONE_TO_MANYandMANY_TO_MANY.In such cases, a custom repository method must be defined - the default
findBymethod cannot handle these field types.This PR adds an explicit error when no such method is provided.
Is this a deprecation? Not really - it's unlikely anyone was using this with unsupported fields, and if they were, it wasn’t working anyway.