Skip to content

[Console][QuestionHelper] add optional timeout for human interaction #61092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Sep 12, 2025
Merged

[Console][QuestionHelper] add optional timeout for human interaction #61092

fabpot merged 1 commit into from
Sep 12, 2025

Conversation

@janedbal
Copy link
Contributor

@janedbal janedbal commented Jul 10, 2025 •
edited
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues None
License MIT

About:

  • Adds timeout functionality to console questions, allowing developers to set a maximum time limit for user input.
  • Our usecase is that some developers added interactive questions inside opened db transactions. Without timeout, it can lead to hours long trx if somebody forgets to repond and keeps the terminal open.
  • The feature is backward compatible - existing code continues to work without timeouts unless explicitly set.

@janedbal janedbal requested a review from chalasr as a code owner July 10, 2025 11:16
@carsonbot carsonbot added this to the 7.4 milestone Jul 10, 2025
@carsonbot carsonbot changed the title QuestionHelper: add optional timeout for human interaction [Console] QuestionHelper: add optional timeout for human interaction Jul 10, 2025
stof
stof reviewed Jul 10, 2025
View reviewed changes
janedbal
janedbal commented Jul 10, 2025
View reviewed changes
@OskarStark OskarStark changed the title [Console] QuestionHelper: add optional timeout for human interaction [Console][QuestionHelper] add optional timeout for human interaction Jul 10, 2025
OskarStark
OskarStark reviewed Jul 10, 2025
View reviewed changes
andersonamuller
andersonamuller reviewed Jul 11, 2025
View reviewed changes
@janedbal
Copy link
Contributor Author

janedbal commented Jul 18, 2025

Any chance this get approved/merged soon? I believe those CI failures are not relevant. Thanks

OskarStark
OskarStark reviewed Jul 18, 2025
View reviewed changes
OskarStark
OskarStark reviewed Jul 18, 2025
View reviewed changes
OskarStark
OskarStark reviewed Jul 18, 2025
View reviewed changes
fabpot
fabpot requested changes Aug 17, 2025
View reviewed changes
@janedbal janedbal requested a review from fabpot August 27, 2025 11:10
fabpot
fabpot requested changes Aug 28, 2025
View reviewed changes
@janedbal janedbal requested a review from fabpot August 28, 2025 11:58
fabpot
fabpot requested changes Sep 4, 2025
View reviewed changes
@janedbal janedbal requested a review from fabpot September 10, 2025 09:27
@fabpot
Copy link
Member

fabpot commented Sep 12, 2025

Thank you @janedbal.

@fabpot fabpot merged commit 4808873 into symfony:7.4 Sep 12, 2025
6 of 11 checks passed
@fabpot fabpot mentioned this pull request Sep 12, 2025
Closed
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

+1 more reviewer

@andersonamuller andersonamuller andersonamuller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Console Feature Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

6 participants

@janedbal @fabpot @stof @OskarStark @andersonamuller @carsonbot