[Security] Remove deprecated RememberMeToken::getSecret()
#61011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktherage
changed the title
RememberMeToken::getSecret() and RememberMeToken's $secret property
OskarStark
reviewed
Jul 1, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 1, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
ktherage
force-pushed
the
RememberMeToken-bc-layer-removal
branch
2 times, most recently
from
002f9c9 to
63e71e7
Compare
alexandre-daubois
changed the title
RememberMeToken::getSecret() and RememberMeToken's $secret propertyRememberMeToken::getSecret() and RememberMeToken's $secret property
alexandre-daubois
approved these changes
Jul 2, 2025
Member
alexandre-daubois
left a comment
alexandre-daubois
left a comment
There was a problem hiding this comment.
After the discussion with Oskar is resolved 🙂
welcoMattic
added
the
BC Layer removal
welcoMattic
reviewed
Jul 4, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
xabbuh
requested changes
Jul 6, 2025
Member
xabbuh
left a comment
xabbuh
left a comment
There was a problem hiding this comment.
I think the constructor of the RememberMeAuthenticator class also has to be updated
Contributor
Author
In which way ? I've removed the deprecation notice there : https://github.com/symfony/symfony/pull/61011/files#diff-8cdcb3fe63f51aca31c4a5869e39ffdfcc793d9d855df4498528a56e1bbd32cdL35-L39. Is there something I missed updating this ? |
Member
|
@ktherage That's the token, but there also is an authenticator class. |
ktherage
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
799ce91 to
9767a2a
Compare
Contributor
Author
|
@xabbuh I did it and rebased. Sorry for this forgetfulness. |
fabpot
requested changes
Jul 8, 2025
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
RememberMeToken::getSecret() and RememberMeToken's $secret propertyRememberMeToken::getSecret()
nicolas-grekas
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
9767a2a to
6b614c5
Compare
nicolas-grekas
approved these changes
Jul 8, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I did the missing UPGRADE + CHANGELOG files updates + simplified the serialization logic.
stof
reviewed
Jul 8, 2025
src/Symfony/Component/Security/Http/Authenticator/RememberMeAuthenticator.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
6b614c5 to
a844f14
Compare
nicolas-grekas
force-pushed
the
RememberMeToken-bc-layer-removal
branch
from
a844f14 to
2fea866
Compare
Member
|
Thank you @ktherage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.