[Form] Fix precision loss when rounding large integers in NumberToLocalizedStringTransformer
#60975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 30, 2025
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #60947 |
| License | MIT |
carsonbot
changed the title
NumberToLocalizedStringTransformerNumberToLocalizedStringTransformer
mhbailly
reviewed
Jun 30, 2025
...mponent/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
Outdated
Show resolved
Hide resolved
…StringTransformer` Add type check in `round()` method to bypass rounding for integer values, preventing precision loss for large integers that are still below PHP_INT_MAX. 🤖 Generated with [Claude Code](https://claude.ai/code)
OskarStark
force-pushed
the
fix-number-transformer-precision-6.4
branch
from
dca4cfb to
bf312d3
Compare
Contributor
Author
|
Failure looks unrelated |
Member
|
Thank you @OskarStark. |
Member
|
Sorry I missed that before merge: this breaks on x86, see the windows build. |
Contributor
Author
|
I think #61055 should fix it @nicolas-grekas |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2025
…ark) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Form] Skip windows x86 number transformer test | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #60975 | License | MIT Follows #60975 (comment) Commits ------- a426cdd [Form] Skip windows x86 number transformer test
This was referenced Jul 31, 2025
Merged
Merged
Merged
GromNaN
added a commit
that referenced
this pull request
Sep 20, 2025
…bbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Form] prefer the public API over reflection in test | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I missed this in #60975 Commits ------- baaa7d0 prefer the public API over reflection in test
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.